I see this too with the captcha

Hi, I have seen this same issue if a user enters the captcha incorrectly on a new ticket, and the page refreshes to try again.. the captcha doesn't show up and the ticket entry fails, until you close your browser and open it again.

I have the captcha turned off for now

wms

up

same problem

Someone at a solution ?

well i got the same problem and found two solutions::

1. open /open.php and find

if(!$thisuser && $cfg->enableCaptcha()){

if(!$_POST)

$errors='Enter text shown on the image';

elseif(strcmp($_SESSION,md5($_POST)))

$errors='Invalid - try again!';

}

the problem is in !$thisuser first line in the above example line 23 in original code

replace that line with ::

if(!$thisuser && $cfg->enableCaptcha() && (!$thisclient || !$thisclient->isValid())){

so you will get something like this::

if(!$thisuser && $cfg->enableCaptcha() && (!$thisclient || !$thisclient->isValid())){

if(!$_POST)

$errors='Enter text shown on the image';

elseif(strcmp($_SESSION,md5($_POST)))

$errors='Invalid - try again!';

}

this will allow clients to make a new ticket without captcha if you dont want this follow step 2

2. open /include/client/open.inc.php

and find::

<?if($cfg && $cfg->enableCaptcha() && (!$thisclient || !$thisclient->isValid())) {

as you can see this does the same as my fix in order to get the captcha working make the bug here

replace that line with::

<?if($cfg && $cfg->enableCaptcha()) {

this will show the capcha from now on

Regards,

Jamie Alexander Dekker

Developer, Programmer and System Analyst at

Rotterdam, The Netherlands

Thanks

Thank you this works great!

Hi!

I am suffering the same problem on a new install of v1.60 downloaded from the osTicket site yesterday. I applied the two corrections listed above by Alex1602 but this has not fixed the problem: The captcha is seen by the user the first time they create a ticket in a browser session but then not shown thereafter (so they cannot create a second ticket).

Any ideas on what needs to be done next? Was this thread relating to v1.60?

Any help appreciated by this newbie :-)

Same problem here too. Going to try the posted fix and will report back.

Update

I used the second fix in the above code and it seems to work fine. Thank you!

Not having as much luck

I have tried the second fix and it doesn't work still. Regarding the first fix, I couldn't find just open.php.

In open.php I'm not sure if:

if(!$thisuser && $cfg->enableCaptcha()){

Is a typo and should be

if(!$thisclient && $cfg->enableCaptcha()){

This would stop the Php checking for a captcha post from the add ticket form.

I echoed the errors I got when posting the form and its in this section that causes it.

I believe $thisclient refers to a client that is logged in. $thisuser ( I think ) is only set in the admin pages of osTicket.

I think the reason the captcha doesn't appear because its only needed to stop spam attacks when a user is not logged in.

If you want it to appear all the time then changing the following in open.php

if(!$thisuser && $cfg->enableCaptcha()){

//to

if( $cfg->enableCaptcha() ){

//Or

if( $cfg && $cfg->enableCaptcha() ){

And then changing the following in open.inc.php

if( $cfg && $cfg->enableCaptcha() && (!$thisclient || $thisclient->isValid() ){

//to

if( $cfg && $cfg->enableCaptcha() ){

Great thanks! Just what I needed.

try change script follow

I'm not sure I'm following and with potential typos and going back and forth, I'm not sure what my code should look like.

Wouldn't this have been a bug? If not logged in, you try to add a ticket, and you correctly input the captcha, and miss a required field, the captcha disappears, that doesn't seem to be proper function.

I'm trying to go back to the original installation files to start again, but I just have to remember how I opened the tar file.

** Every time I open the tar file, it extracts another tar file.

** Got it extracted properly.

see link: (http://osticket.com/forums/showthread.php?t=6059)

I just found some possible captcha bug.

Thank you,

bellacrazy74

thanks. this worked for me..

well i got the same problem and found two solutions::

1. open /open.php and find

if(!$thisuser && $cfg->enableCaptcha()){

if(!$_POST)

$errors='Enter text shown on the image';

elseif(strcmp($_SESSION,md5($_POST)))

$errors='Invalid - try again!';

}

the problem is in !$thisuser first line in the above example line 23 in original code

replace that line with ::

if(!$thisuser && $cfg->enableCaptcha() && (!$thisclient || !$thisclient->isValid())){

so you will get something like this::

if(!$thisuser && $cfg->enableCaptcha() && (!$thisclient || !$thisclient->isValid())){

if(!$_POST)

$errors='Enter text shown on the image';

elseif(strcmp($_SESSION,md5($_POST)))

$errors='Invalid - try again!';

}

this will allow clients to make a new ticket without captcha if you dont want this follow step 2

thanks! I found this bug tonight and implementing your fix #1 worked.

it may be worth noting that I also have a MOD to use RECAPTCHA, instead of the one with osticket and this fix worked for me.

I commented out the original line of code and replaced it with your line of code and it worked like a charm.

NO CAPTCHA is needed for a user that is already logged in.

if(!$thisuser && $cfg->enableCaptcha() && (!$thisclient || !$thisclient->isValid())){

thanks and best regards,

nico

now i just have one more little bug to figure out and I'm good to go to production! :)