jothie

I was able to upload this example just fine. How about right click the page, click Inspect, click Network, check the box to Preserve Logs, upload the file, click the request in the Network tab, click Response, and see what the response says.

Cheers.

It's an 8,6Mbyte MP4 file and i can't upload it here.

So here they are:

jothie The Response tab

Attached the response tab:

jothie

So apparently the file is invalid in your case somehow but it wasn't for me. Apparently the given MIME TYPE doesn't match the MIME Type returned from FileObject::mime_type():

• https://github.com/osTicket/osTicket/blob/develop/include/class.forms.php#L3975-L3977

Cheers.

You're right, i have commented out this lines:
// Make sure mime type is valid
//if (strcasecmp(FileObject::mime_type($file['tmp_name']),
// $file['type']) !== 0)
// return false;
and it works.
It have checked the old source 1.17.1 -> This lines seems to be new in 1.17.2 or 1.17.3.

Many thanks for your help.

jothie

Yes, it's a security patch. But it's very strange that I'm able to upload this and you are not. I wonder what the difference is here..

Cheers.

jothie

Can you please create a PHP file in your osTicket directory, paste the following content, visit the file in the browser, and tell me what the page displays?

<?php
var_dump('finfo_open exists: ', function_exists('finfo_open'));

Cheers.

We're having the same issue. Had to comment out this as a temp fix:

https://github.com/osTicket/osTicket/blob/develop/include/class.forms.php#L3975-L3977

jothie , we had the same issue with saving emails on Mac vs windows. The difference was that Mac uses .eml files which work ok, Windows uses .msg, which does not work.

I'm not sure if you're having the same problem.

we have the same issues after updating to v1.17.3, we used version 1.17.2

melgsondouglas

solved by activating the fileinfo in the php manager

KevinTheJedi

The problem ist that $file['type'] and FileObject::mime_type($file['tmp_name']) do not return the same result.

in case of a zip-file:
string(28) "application/x-zip-compressed"
string(24) "application/octet-stream"

samplefile attached

bauernbengel

Yes, I have seen this with someone else, however I’m unable to replicate this with ZIP files in my instance. What version of PHP are you using? What browser are you using? What OS are you using when uploading the file?

Cheers.

Ugly Fix:

class.forms.php replace the function

static function isValidFile($file) {
    // Make sure mime type is valid
    #var_dump($file['type'], FileObject::mime_type($file['tmp_name']));die;
    #if (!empty($file['type']) && strcasecmp(FileObject::mime_type($file['tmp_name']),
    #            $file['type']) !== 0)
    #    return false;
    // Check invalid image hacks
    if ($file['tmp_name']
            && stripos($file['type'], 'image/') === 0
            && !exif_imagetype($file['tmp_name']))
        return false;
    return true;
}