[resolved] Images not appearing in print

TheDeadGuy

Hi,

When printing tickets, the images that are in the tickets come up with a red cross instead of displaying the image.
(Happens to the logo too, but think that's another issue)

I've recently updated the system to php 5.6 from 5.4.

I've seen posts regarding this issue, but i believe they were all relating to version 1.10 and not 1.11

Any suggestions?

Thanks

ramrajone

TheDeadGuy
When you looking at the ticket you see image, but when you try to print it has x?
Have you tried a different browser?
Also, are you using any plugin to display images?

TheDeadGuy

ramrajone

Just to clarify, by print i mean the print button which creates a PDF.

I've tried on Firefox and Chrome.

When looking at the ticket, you can see everything and it's all ok, but when you go to print pdf it shows red x where the image is supposed to be.

TheDeadGuy

Hi,

An update. Just updated my test server to PHPv7 and it has not resolved the issue. PHP version is not the issue here.

ramrajone

TheDeadGuy
Firefox and Chrome have built-in PDF previews, I had never printed ticket hehe, just tested and it's not working for me in both version 1.10.4 or 1.11

This is what I get:

ntozier

I do not have the same problem... but I note that when I print something it does not use my custom logo.
/goes off to look at why that is
BRB!

ntozier

When you print it apparently uses the "Client" selected logo in Company -> Logos.
the size appears to be 336.41 x 70.

If I change the client logo back to built in one it works again.

This sounds to me like it is a bug. Looks like it started in 1.10.
https://github.com/osTicket/osTicket/issues/3770

TheDeadGuy

ntozier
Hi,

I resized the image to that resolution with no luck.

ramrajone

ntozier
I looked at that link and it happens both image/PDF, should I open my own post here or report via GitHub?

TheDeadGuy

@ramrajone
Not sure what you're showing me. but here's a step by step image guy to show you what is happening

You have the top of your ticket:

You click it and print the ticket which creates a pdf.
In the pdf, the images that were in the response are not shown.

These are the images in the response:

This is what i see in pdf:

For the logo, if i set it to the support center image, it works but doesn't work for any of the ones i upload. I even resized one to be exact same pixel size as the support one, but it still doesn't show.

ramrajone

TheDeadGuy
Yes, that's what I getting too, if it's images, if it's PDF it shows NameOfPDF.pdf

TheDeadGuy

An update,

I have this issue on 2 seperate test servers, as well as my main server.

i've made the change from the github help topic https://github.com/clonemeagain/osticket-plugin-archiver/issues/4

The changes from there did not correct the issue.

TheDeadGuy

Solution:

Find the last known version of osticket that worked.
For me that would be 1.11rc or 1.8git with schema 00c949a623b82848baaf3480b51307e3.

I copied class.pdf.php and the folder mpdf from the old version, copied it to the new version.

bish bash bosh, it's all working

KevinTheJedi

@TheDeadGuy

This isn't an actual fix...also that doesn't make sense as the RC release used the old MPDF and v1.11 stable uses new MPDF. When you copied over the include/class.pdf.php file did it include the line:

require_once(INCLUDE_DIR.'mpdf/mpdf.php');

If so then you're still using a version that is not v1.11 stable. We need to find the actual issue here instead of using old files.

Cheers.

ramrajone

@KevinTheJedi

I just looked at the include/class.pdf.php it does NOT have require_once(INCLUDE_DIR.'mpdf/mpdf.php');

I downloaded a fresh copy of v1.11, I tried putting in on line 17 and before line 16, but still did not work.

KevinTheJedi

@ramrajone

We have found and addressed the inline image issues with PDFs. A pull request will be submitted very soon so please stay tuned.

Cheers.

ramrajone

KevinTheJedi
I just tested https://github.com/osTicket/osTicket/pull/4790

it works for images, should it work for.PDF files too? because it does not work for pdf files

include/class.pdf.php
change line: 42
from:
$self->{$key} = $file->getData();

To:
$self->imageVars[$key] = $file->getData();

include/mpdf/vendor/mpdf/mpdf/src/Config/ConfigVariables.php
line: 265
from:
'ignore_table_percents' => false,
'ignore_table_widths' => false,

To:
'ignore_table_percents' => true,
'ignore_table_widths' => true,

ntozier

Please see:
https://github.com/osTicket/osTicket/pull/4790