PHP 7.2

andersb

Hi, first of, let me say that I'm very glad for the work you guys do with osTicket, it is absolutely awesome!

I just learn that our web hosting company is removing php 7.0 by the 3rd of December and from other posts (and testing myself) osTicket 1.10.x/1.11.x does not support php 7.1 or 7.2.

In this discussion, https://forum.osticket.com/d/92229-php-7172/7
@DiegoZuccato is mentioning that 1.11.x RC1 can work with php 7.2 with some minor modifications.

Since I know next to nothing about php, I would love it if someone could say exactly what he changed
Line 1662 is that file looks like this

extends BaseList

ntozier

He did not post in that thread what he did to fix the "error".

andersb

Unfortunate no. I did find my way into osTicket github where PHP 7.1+ seems to be a hot topic as well.
From what I can tell, there isn't just a single row in one file that needs to be changed which makes it way to complicated for me to try and fix myself.

I know you're reluctant to reveal any release dates so I will just wait for a while and see if anything pops up ?

ntozier

I'm not reluctant to reveal them. I simply do not know them. ?

KevinTheJedi

@andersb

The stable release of 1.11 (coming very, very soon) will support up to PHP 7.1. Version 1.12 might support PHP 7.2 (hopefully).

Cheers.

andersb

@KevinTheJedi , support for 7.1 will solve my problem so that is great to hear!
Thanks again for an excellent product!

DiegoZuccato

Sorry. Didn't post the patch because it seemed obvious. Here it is:

--- class.orm.php.ori	2018-07-17 11:57:26.000000000 +0200
+++ class.orm.php	2018-10-25 14:33:21.388766785 +0200
@@ -1715,7 +1715,7 @@
         throw new Exception(__('QuerySet is read-only'));
     }
 
-    function count() {
+    function count($mode = COUNT_NORMAL) {
         $this->asArray();
         return count($this->storage);
     }

andersb

DiegoZuccato , this seemed like a very easy fix but unfortunately not.
Without any modification, the login page doesn't load at all (forced by web hosting company to use PHP 7.1)
After updating the file like you mention, the login page will load but you can't login. You will be redirected back to the same login page even if credentials are correct.

ntozier

code updates should be done over on github. ?

KevinTheJedi

@andersb

Use this man:
https://github.com/osTicket/osTicket/pull/4344

Cheers.