I'm sorry for so many questions, but I have to ask.When my plugin runs the menu items are replaced with the relative url of my plugin.Instead of the normal http://myosticket/scp/dashboard.php, I have http://server/myosticket/scp/dispatcher.php/mypluginpath/dashboard.php.The latter, of course, won't work.  The only way I know to fix it is something in the navigation.tmpl.php file like,echo sprintf('<li class="%s %s"><a href="http://myserver/osticketdev/scp/%s">%s</a>',I really feel like this is a lot of hacking though.  I could make it more elegant, but should I be fixing this in the core?  When I upgrade it will go away.edit:  or this, echo sprintf('<li class="%s %s"><a href="' . ROOT_PATH . '%s">%s</a>',

I would think that you would want to address this in core (via github PR).

Can you tell me what PR means?Edit:I opened this,https://github.com/osTicket/osTicket/issues/3125

I hate to ask this, but did I do the PR correct?https://github.com/osTicket/osTicket/pull/3126It says I want to make two commits, but those are not mine (they are the main dev. I think.)What do I do from here?

Basically you're supposed to fork the whole repo for osticket, make your changes in your forked repo, then make a pull request against the original repo. It should include all commits and changes you've made to your repo so the main repo can replay them. It'll even tell you if it directly conflicts etc. After you've changed something in your repo github will ask if you want to create a pull request. Can technically do it all in your browser.

Easiest way to start is simply click the edit link on any file and it should fork it for you.

Have another go mate.

I just tried again, and I think I did what you said,  and I apologize in advance if my comments in the Pull Request made no sense.  Essentially I proposed a change, and then it looked like it had already been addressed (differently than I did), but then I found where the develop branch change did not work with one of the other files (header.inc.php in staff).  I used what I proposed to "fix" it, so all I know to do is let you look and judge what to do.Thanks for your patience.

Write a Reply...