- Edited
This is exactly what i'm looking for, thanks Sosamv.Any chance we could get an upgraded version for v1.9.4?Thanks again!
Help Topics in multiple combos
- Edited
We have a large number of help topics as well and are looking for the same functionality. Will have to give this a try. Thanks for the post!
6 days later
- Edited
It appears that after applying this modification, the ability to create new topics is now broken...See below, the Add Topic button for new topics is gone :(
EDIT: I have narrowed the issue down to being a problem with class.topic.php - unsure what line is breaking the save / add topic buttons ATM as I am not a coder.Hopefully sosamv responds!
- Edited
Maybe problem is here (scp/helptopics.php) on POSTcase 'create': if(($id=Topic:($_POST,$errors))){ $msg=sprintf(__('Successfully added %s'), Format:($_POST)); $_REQUEST=null; }elseif(!$errors){ $errors=sprintf(__('Unable to add %s. Correct error(s) below and try again.'), __('this help topic')); } break;
- Edited
i've tried it on 1.9.4, i've not copied the files over, i've compared the modded files with 1.9.3 to work out what the changes are, and copied those changes into the 1.9.4 files.no errors being displayed. and no problems creating new help topics.but trying to go in as a client and open a new ticket, i just get an empty page. maybe i'm missing something obvious, but i'm seeing no difference in the open.php from 1.9.3 and the modded file uploaded on sept 5.
- Edited
^ Im getting the same experience as nhybgtvfr. Going to double check everything
- Edited
just tried placing the modded files straight into the 1.9.4 system unaltered, get the same problem powdergeek11 had.going through it all again from scratch, a bit more carefully this time. fortunately it's just a test server, so i can get away with breaking things :)so far, i've modded the 1.9.4 versions of open.php and open.inc.php, and adding a new help topic can still be done without any problems. a client attempt to open a new ticket loads the part of the page, but obviously doesn't get the selection parts yet.seeing:
Guest User | Sign In
Support Center Home Open a New Ticket Check Ticket Status Open a New TicketPlease fill in the form below to open a new ticket.
Help Topic:just working through the changes to class.topic.php now, will update again soon.- Edited
finished changing class.topic.php tried creating new help topics, worked fine. tried creating a new ticket as a client, that worked as well.i've gone 3 levels deep on the topics, select a topic with only 1 level i get{"media","html"} after the contact details,selecting a topic with 2 levels of depth, i get the same after selecting the 2nd level topic.selecting a topic with 3 levels of depth (no spaces in any of the topics), i get the same after selecting the 3rd level topic.getting some really messed up stuff on a selection with a custom form, but that may be related to something else. going to wipe out custom forms and existing help topics and test again. in the meantime, i've attached the modded 1.9.4 files i'm currently using.
- Edited
i can't get any further with this. i'm not sure if some custom forms / lists that i was playing around with before is causing some issue. i deleted all custom forms, but can't delete some custom lists because it say's they're in use by custom forms?!?looking at it, it looks like when the final option is selected, it's trying to call a dynamic form, which is being returned null values, when i don't believe if should be even calling it. i've deleted some of the custom form / list stuff i found still lurking in the database, but may have missed stuff.i'm now going to try going back to a new clean install and re-applying the mod and see how it works on that.in the meantime, once it's working fully, i'd like to see only the 1st drop down list, with the others only showing up, if required, once a selection in the parent drop-down has been made. the created page code shows the inactive drop-downs as disabled, anyone know how to make it so they're hidden?<select name="topic2" disabled="" class="cmb" id="cmb2" style="width: 300px; float: none;"> </select>
- Edited
Thanks nhybgtvfr, Everything works fine only one problem. I have 3 level and after the selection of third level I get {"media","html"}.
- Edited
yep. getting the same thing myself, just restarted it all with a completely new database, to confirm it wasn't anything else left over from custom forms causing it, but i still get the same thing. even like this, as far as i can tell, creating a new ticket still works without any problems. i tried before with a custom contact form, and it made a complete mess of that, with html tags and symbols showing up all over the place.your custom ticket details part looks ok though, so maybe anything other than a customised contact form may be ok.looking at the code some more, it looks like the help topic drop downs and the contact form are being created within the same tbody /tbody tags, with ticket details and captcha each in their own tbody, i *think* the help topic part and the contact details part should both be in their own tbody. but i'm in no way, shape or form, a programmer, i've managed to hack it this far, but i think someone with a bit more knowledge than me will need to fix this part.
- Edited
ok. the remaining issue has nothing to do with the contact form being in the same tbody, that said, i still think the contact form *should* be in it's own tbody, which can be achieved by editing include/client/open.inc.php and adding</tbody><tbody>just above these lines:<?php if (!$thisclient) { $uform = UserForm:()->getForm($_POST);the issue is being displayed by this bit of code: <tbody id="dynamic-form"> <?php if ($form) { include(CLIENTINC_DIR . 'templates/dynamic-form.tmpl.php'); } ?> </tbody> i've moved it to the end of the table, so it doesn't affect any of the other forms.its being called by this bit of code, in the same file, with the highlighted line being the cause. i've commented the line out, and the issue no longer displays, although i can't confirm that won't cause any other issues. not worked through that part yet.var changeCombo = function(){ var value = $("#cmb_value").val(); var data = $('', '#dynamic-form').serialize(); if(value ==""){ $('#dynamic-form').html(""); }else{ $('#dynamic-form').load('ajax.php/form/help-topic/' + value , data); }}
- Edited
ok, you can't just comment out the line below, if you do, it will not load any custom forms. $('#dynamic-form').load('ajax.php/form/help-topic/' + value , data); the actual data being returned by 'value' in that line appears to be fine, it matches up with my help topic id's. there doesn't appear to be anything spurious being included.when there are no custom forms it just displays {"media","html"} , i have no idea where it gets this from, they're not in the database, and the strings media and html only appear together in include/mpdf/classes/cssmgr.phpif you do use a custom form, it appears on screen, mangled, like:\n\nAffected Site<\/h3>\n<\/em>\n <\/div>\n <\/td><\/tr>\n\n Website URL::<\/label>
- Edited
I think they are getting the values from this file include/class.forms.php
7 days later
- Edited
well, i don't seem to be getting any further with this. looks like i'm gonna have to leave this one to someone with some real programming knowledge.
- Edited
Hello guys,
Here's the code as promised. I made the change pretty quickly cause I have a short delivery time, so don't judge my coding skills hahaha. The 3 files I changed are the following:
C:\wamp\www\osTicket\open.php
C:\wamp\www\osTicket\include\client\open.inc.phpC:\wamp\www\osTicket\include\class.topic.php
I'm attaching them here in a 7zip folder. Just by repleacing those files it should be working right away. Let me know If you have any problems.
Jerry
Thanks!! That worked PERFECTLY!
6 days later
- Edited
normal">Hello friends,
mso-fareast-font-family:"Times New Roman";mso-fareast-language">
normal">fixed the problem with {"media","html"}
by reediting the ajax function in the open.inc.php
15.3pt">Just exchange
$('#dynamic-form').load('ajax.php/form/help-topic/'
+ value , data);
with $.ajax('ajax.php/form/help-topic/' + value,{ data:
data, dataType:
'json', success:
function(json) { $('#dynamic-form').empty().append(json.html); $(document.head).append(json.media); }})works like a charm for me!I will add the file as an attachment
15.3pt">Another thing is, that in the multi-dropdown version
the customer would not be able to post a ticket with just the "parent
topic"For Example when you have a topic "A" and
topics "A / B", "A / C" you a forced to use either "A
/ B" or "A / C" but never just use "A"I think is might be clever to give this opportunity to
the user, because sometimes you just don’t know where the problem really comes
from.So I just changedif(sel.attr("disabled") ===
"disabled"){toif(sel.attr("disabled") ===
"disabled" || sel.val() === ""){and it's working as far as i see now.Next thing i want to change is dynamically showing or
hiding of needed or not needed dropdowns.For example when i have a topic with just 2 levels and
one with 3 I don’t want to show the 3rd dropdown when the customer selects the
topic with just 2 levels.i hope all of this was understandable, normally i just
talk English but never write anything ;)
- Edited
kudos Suntas. This fixes all the problems, at least for now ;)Will it be possible for you to look into adding cascading drop down to other fields too apart form help topic. Thanks
- Edited
cool. will check it out tomorrow. don't have time right now.would never have worked out that fix myself :(re: hiding dropdowns, what would be ideal is if it only showed the 1st level dropdown, and then expanded to show each sub-level dropdown only once a selection is made that actually requires it. so even if every help topic has at least 3 levels, only the top-level dropdown is shown when the page is first loaded.
- Edited
Got it!Now the dropdowns only get displayed when needed.So startingpoint is dropdown 1, dropdown 2 gets displayed after selecting an option in 1 but only if there is anything to select.Just a tiny jquery script and 1 line of php code to hide the dropdowns on start.File is attached!@ bond007: don't know at the moment. I will try to look into it.