Can't update from 1.15.5 to 1.17.4 - Upgrade Fails

severdia

@KevinTheJedi I tried again following those exact instructions and got the same problem.

KevinTheJedi

severdia

Open your bootstrap.php file and tell me what line 369 is.

Cheers.

severdia

@KevinTheJedi

define('THISPAGE', Misc::currentURL());

KevinTheJedi

severdia

Seems like your code wasn’t completely updated as this line has since been updated.

Cheers.

severdia

@KevinTheJedi
Keep in mind this is the reverted version. The one when the upgrade breaks looks like this. So it's just a comment.

KevinTheJedi

severdia

Okay that looks fine. Redo the upgrade and see what error you get.

Cheers.

severdia

@KevinTheJedi That's the file AFTER the failed upgrade. I can't get any further than what I've already posted above.

KevinTheJedi

severdia

So let me get this straight..you replace the code with the new code, you run the upgrade, and you get the Misc::currentURL error? If so that makes no sense unless you need to restart your webserver to clear file cache.

Cheers.

severdia

Yes, that's correct. It's the same error whether I run the update via Softaculous or do it manually. It'd be great to know what "Something went wrong" meant or why there's an error on that line.

KevinTheJedi

severdia

That line shouldn’t be there in the new code is what I’m saying. It sounds like your server is still serving the old files somehow.

Cheers.

severdia

I downloaded the 1.18 package from the osticket.com website and uploaded it to the server and manually ran the update. What do you mean by "that line shouldn't be there in the new code"? It's what I downloaded from osticket.com.

KevinTheJedi

severdia

This line:

define('THISPAGE', Misc::currentURL());

The error you are getting is PHP Fatal error: Uncaught Error: Non-static method Misc::currentURL() cannot be called statically which should not happen as this line was removed and should not exist in v1.18. Unless of course this error was logged before you updated the code; which you haven't confirmed. If that's just an error generated by the old code and does not actually occur on upgrade then when the upgrader fails look at the Dashboard > System Logs for any errors.

Cheers.

severdia

@KevinTheJedi That's the file I downloaded from https://osticket.com/download/

KevinTheJedi

severdia

I think we should start over here..

Clear your error logs or just remember the last entry. Update the codebase to v1.18, run the upgrade, and if it fails check the error logs again. If you don’t see an error there check your Dashboard > System Logs for any related errors.

Cheers.

severdia

Same error and this is what the System Logs looks like.

The "task pending" appears to be the last three issues listed here that are stuck.

KevinTheJedi

severdia

So you get a new error with Misc::currentURL()? If so your server is messed up somehow. You should restore from backup, update the code again, restart your webserver to clear any file cache, and redo the upgrade. You may also need to contact your hosting provider to see how to fully clear the file cache on the server. Some hosts have tools in CPanel to do this for you.

When the upgrader gets stuck on a Task then you can simply click Upgrade Now and continue the upgrade. Your host has some timeouts enabled and the upgrade Task is taking too long so it timed out. You can continue the upgrade by clicking Upgrade Now.

Cheers.

severdia

No, the error has always been the same. Nothing is timing out because it happens instantly. I'll ask my hosting provider to take a look, but I don't think it has anything to do with the cache.

KevinTheJedi

severdia

Then idk something odd is up with your setup.

Cheers.

severdia

My host says there's no server cache or anything that would affect the setup and technically this is outside the scope of their support (as I suspected). They restarted the server and I tried again with the exact same result. This is clearly a bug in the the upgrade scripts for OSticket and that's where the error log points. If the stance is "not our problem", I'll try another solution.

KevinTheJedi

severdia

That's not the stance just can't replicate your issue and it really doesn't make much sense. There is not enough information to go off of here. You are positive a brand new error PHP Fatal error: Uncaught Error: Non-static method Misc::currentURL() cannot be called statically with a new timestamp is logged when you run the upgrade script? Or is the only thing that happens is the upgrade failed notification and that's it?

Have you checked your other logs (general server logs, webserver error logs, PHP error logs, MySQL/MariaDB error logs, osTicket System Logs, Browser Console logs, etc.) for any related errors?

Cheers.