Schedules - Blank Form For Non-Recurring Entries

BPS-IT

I was going to update the stat holidays for next year and encountered a blank form when selecting the holiday. When I look at the PHP log I see the following error...

PHP Fatal error: Uncaught ArgumentCountError: DateTime::setTimestamp() expects exactly 1 argument, 0 given in C:\inetpub\wwwroot\osTicket\include\class.schedule.php:958

When I looked up the SetTimestamp function it requires a value so the error makes sense.

This is the excerpt from the file in question...
// TODO: Add support for 'ends_on' - We don't support date
// range at the moment - assuming ends on the same day.
$source['ends_at'] = $ends->format('h:i a');
if (($stops=$this->getStopsDatetime()))
958--> $source['stops_on'] = $stops->setTimestamp();

NOTE - This only happens for ONCE type entries. Recurring / Repeating entries work fine.

Curious as to how to properly resolve this error.
Thanks!

KevinTheJedi

BPS-IT

Here is a pull to address the issue:

https://github.com/osTicket/osTicket/pull/6324

Cheers.

BPS-IT

Thanks Kevin! The Fatal error is no more however now the item will not save.

I click save and it looks like it updates but the form doesn't close and the write to DB doesn't occur.

For now - If I rem out Line 958 I am able to get the write to happen but it will only load one item and then needs a page refresh to load the other.

I doubt this was the best approach but it has done the trick for me till next year so just something to look at for a future release.

Loving OST!