Regex on custom form field

AMH1896

I have created a custom form with multiple fields and each field's validator is set to Custom (Regular Expression). All the other fields work just fine except for one field. The field has the Regular Expression set to ^0\d{6}$ I have also tried ^[0]\d{6}$ The user is to enter a 7 digit number that must begin with zero (0). The ticket throws a validation error if the field in question doesn't begin with a zero (0); is more than a total of 7 digits including the zero; and/or is less than 7 digits. The problem is there are time the user will need to enter 7 zeros. I have checked my Regular Expression on different websites and with those much more experienced than me. All say either expression is correct. You can look and test the expression here: RegEx101

Server Info:
osTicket Version v1.14.3 (f4f5bc6) — Up to date
Web Server Software Apache/2.4.29 (Ubuntu)
MySQL Version 5.7.30
PHP Version 7.4.10

KevinTheJedi

@AMH1896

This is a bug where we use the equals comparison operator to check if $value == '0' and if true we change the value to &#48 which is 0. In your case 0000000 is considered to be equal to 0 so it gets changed and does not match the REGEX statement. I have made a pull request to use the identical comparison operator === instead so it matches 0 (string) literally. Here is a link to the pull request:

https://github.com/osTicket/osTicket/pull/5642

Once you make the changes the REGEX statement should pass.

Cheers.

AMH1896

KevinTheJedi

Thank you. I was just about to jump over to GitHub and submit an issue. I will modify the core file and test it out.