Extend or remove file links expiration

huntmknox

Hello,

I'm having an issue with attachments and links expiring. Is there a way to remove this or increase the expiry? I see in the help bubble the explanation:

From a security perspective, be aware that the user's browser may retain previously-viewed files in its cache. Furthermore, all file links on your helpdesk automatically expire after about 24 hours.

The link to the attachment contains a timestamp:

https://tickets.domain.com/file.php?key=gtjud45fb8yic_ow6t0hfd-07kqtkpce&expires=1558137600&signature=89e812fbc69ac442e46a91a32584814b55adb2a1&id=19764

The attachements are saved to the database. We do have the file storage plugin installed but it's disabled.
Running v1.12 (a076918)
MySQL Version 5.5.60
PHP Version 5.6.40

Thanks

KevinTheJedi

@huntmknox

It would not be a good idea but it's open source and you're allowed to do whatever you want. If you want to change this behavior look into include/class.file.php.

Cheers.

EIJason

KevinTheJedi Questions if files are on the file system are they available forever? they dont expire right?
if I can get attachments to work we need them forever... 😉

huntmknox

Thanks for your help! I would like to increase it as the attachments contain important ticket related data and some tickets take a week or more to close...

Can I change these values to extend it or will that break something?

    $minage = @$options['minage'] ?: 43200;
    $gmnow = Misc::gmtime() +  $options['minage'];
    $expires = $gmnow + 86400 - ($gmnow % 86400);

EIJason

Can we have an option in the setting of expiry time or none at all?
Sometime you want to go back on old attachments to see the history our time frame for what we will user it for may be a matter of months....

KevinTheJedi

@EIJason

Can we have an option in the setting of expiry time or none at all?

Like I said, this is not a good idea from a Security perspective but you can do it. Just look in include/class.file.php.

Questions if files are on the file system are they available forever? they dont expire right?

Of course, all files regardless of StorageBackend are available forever. Just the file links themselves that are sent out in alerts will expire. Attachments/inline images will always be viewable in the thread.

Cheers.