Checkbox in Custom Field

ticketme

I saw on GitHub (https://github.com/osTicket/osTicket/issues/2116) this issue was potentially fixed in previous versions but it seems to have crept back in 1.11.0.
I created a custom field in the Ticket form with a checkbox option. I can successfully "check" the checkbox and update the ticket, but I can't uncheck the checkbox.
If I click on the field and try to uncheck the field in the popup dialog box, I get an error saying "Unable to update field" and further comment saying the field name "is already assigned this value".
If I click on the edit ticket link which takes you to the full form and try to uncheck the field, it says the ticket updated successfully, but the field value still remains checked.

ticketme

Did some digging and found that when you serialize a form, it does not register unchecked check boxes (https://api.jquery.com/serialize/). This would explain the behavior and the error. Still working on a fix for all custom fields with checkboxes. If I get desperate I may just implement something for my one field.

ticketme

I think I figured out how to fix this bug. It was complicated because different forms submit in different ways. On top of that, the value of checkbox inputs are set to the ID of the custom field. Even with that being said, I was able to modify some code I found on a forum to fix this issue. I tested it with multiple custom checkbox fields in both the Tickets and Tasks forms. It should also work with custom forms, but let me know if you run into issues.

Edit scp/js/scp.js
Line 702
Change
function(e) { submit_button = $(this); });
to
function(e) { submit_button = $(this); uncheckedPrep(); });

At the bottom of scp/js/scp.js add this:
function uncheckedPrep() {
$("form").submit(function () {
var form = $(this);
form.find('input[type="checkbox"]').each(function () {
var currentCheckbox = $(this);
// Hides all checkboxes before submit to avoid confusion of all checkboxes looking checked
currentCheckbox.hide();
if (currentCheckbox.is(':checked') == false) {
currentCheckbox.prop('checked', true);
currentCheckbox.attr('value', '0');
}
});
});
}
uncheckedPrep();

Update: I submitted the bug and fix to osTickets Github (https://github.com/osTicket/osTicket/issues/4782)

ntozier

Thanks for the submit!