Plugin TinyMCE: Page 2 - osTicket Forum

Plugin TinyMCE

Micke1101

Ok i just checked the table of contents plugin and it seems that it's doing what it's expected to, but htmlawed seems to be filtering out the id's so the links are correct but the anchors are removed by osTicket.I unfortunately don't think there's much that can be done to prevent this, unless you modify core code, i will however have a look later on.https://github.com/osTicket/osTicket/blob/864249338073cf8d7357c04486b90e1119edcde9/include/class.format.php#L319

blueyeguy

While troubleshooting a different problem, I noticed this error in my PHP log, it doesn't appear to affect how it works, and I haven't had a chance to see what it's referring to because as I said I am troubleshooting a different problem lol, but thought I would pass this along. PHP Warning: scandir(/js/tinymce/skins,/js/tinymce/skins): The system cannot find the path specified. (code: 3) in C:\inetpub\wwwroot\support\include\plugins\OSTicket-plugin-TinyMCE-master\config.php on line 40 PHP Warning: scandir(/js/tinymce/skins): failed to open dir: No such file or directory in C:\inetpub\wwwroot\support\include\plugins\OSTicket-plugin-TinyMCE-master\config.php on line 40 PHP Warning: scandir(): (errno 2): No such file or directory in C:\inetpub\wwwroot\support\include\plugins\OSTicket-plugin-TinyMCE-master\config.php on line 40EDIT: this error seems to correspond with my cron job interestingly enough, I have cron shut off at the moment because of a mail fetch problem I am having and these errors stopped as well and were occuring at the same interval as my cron job.

Micke1101

@[deleted] Thank you, I don’t have cron on my test so haven’t seen this.

The scandir should only be on the config page, so weird that it’s called on a cron job.I've now added a check so that it should no longer give you a warning regarding the scandir.

cnedelcu

OH MY GODMicke1101, you are our savior. Your plugin works extremely well !I followed your instructions and it worked right off the bat.Thank you so much!!! You have no idea what you just did for us :-)

Micke1101

Great to read that you enjoy it :)

blueyeguy

+1 This is great and our agents love it. The only thing thing that doesn't seem to work for us is the "browsers native spellchecker", but our agents just need to learn how to spell :-)

Micke1101

@[deleted] that's strange, what browsers are they using? any add ons active? what tinymce plugins do you have running?

blueyeguy

@[deleted]01 I'm sure it's a mix of Chrome and FireFox, and a few Apple users with Safari, I doubt any use IE or Edge. I personally use both Chrome and Firefox (my queue open in FF, and logged in as admin to see all tickets in Chrome) and I think AdBlock Plus is the only addon we have installed other than Flash, Java, etc.Here's a pic of my config page blank

Micke1101

@[deleted] it looks like when i commited the fix for autosaving, i commited an old version of 2 files that didn't have the browser spellcheck in them yet.Now it should be back and working.

blueyeguy

Brilliant! But now my lazy agents don't need to have any spelling ability. Thanks tons for all you do for the community @[deleted]01

sperrow

Hello @[deleted]01, this is superb work you have done :) Can anyone please confirm if Organisations notes work when using this plugin? As currently it shows only empty, editable box, but without text controls.P.S. Maybe it is worth to add "forecolor" before "backcolor" in Toolbar setting by default, as text colour quite possibly is used more than background colour. Just my two cents :)

Micke1101

@[deleted] you're absolutely correct, it looks like scp.js calls the redact function that the plugin removes: https://github.com/osTicket/osTicket/blob/770174cffaba74fae171bd3ec859491f42fdd4e1/scp/js/scp.js#L1106It seems to only be used for quick notes, i'll have a look at what will be the best course of action.Either rename the tiny to redact so that it calls the old function, or replace the whole note function at runtime.

blueyeguy

@[deleted] I can confirm that I am unable to create a note on an organization. We barely use orgs so I have not tried to do this since adding the plugin..

bijl

What a fantastic plugin Micke1101 !! Thanks a lot for it. One small thing: in a reply an image can be added by drag and drop, but adding an image by drag and drop in a new canned response, the image is saved in base64 code. Is there a way to fix this ?

Screen Shot 2017-10-28 at 00.26.20.PNG

Micke1101

@[deleted] I'm unable to replicate what you're describing.Can you provide what webserver you're using, what browser and version, plugin configuration and an example image?

drag and drop.PNG

drag and drop source.PNG

Micke1101

@[deleted] and @[deleted] can you please try the latest commit, it should sort out the issue with quick notes.

bijl

I am on macos 10.13, chrome Version 61.0.3163.See enclosed screenshots for plugin and serverinfo.Found out that it works fine unless the size of the image remains under 50KB.

Screen Shot 2017-10-28 at 00.26.20.PNG

Screen Shot 2017-10-28 at 15.16.15.PNG

Screen Shot 2017-10-28 at 15.19.42.PNG

Screen Shot 2017-10-28 at 15.15.00.PNG

Micke1101

@[deleted] I've now tried on a mac with chrome, apache with php 5.6 and i can still not replicate this issue.There does not seem to be a difference for me when dropping a sub 50kb file or greater either.What i can see differs so far is that you've enabled the powerpaste plugin, i have not purchased this plugin so i'm unable to test if this could be the issue.Can you try disabling the powerpaste plugin?The fact that you're seeing the raw html code makes me wonder if it could be a javascript error, can you check if you get any error messages in the console as well?

bijl

disabled the powerpaste plugin: same result.did a fresh install & latest version of the plugin: still the same.As we are making use of a lot of images in canned responses, it would be handy if it should work, so we are open to any suggestion. On the other hand we can switch to an external file storage service and paste the link. We are very happy with this plugin anyway. Thanks a lot for your effort!

sperrow

Hi @[deleted]01,I just tried organisational notes and they work brilliantly :) Awesome work.I have a little question regarding osTicket/js/tinymce (sorry it if has been answered before somewhere), but I see that this directory contains langs and skins directories, which also exists in plugins/tinymce/. In skins directory in js/tinymce, the only difference from the main skins directory in plugins/tinymce/skins/ is that js/tinymce/skins contains charcoal skin. Also looking further down the directory tree, I can see plugins/tinymce/skins/lightgray contains more files than js/tinymce/skins/lightgray/Are these somehow referenced? (haven't looked into the code yet, sorry) if not, is it something people should copy over? It is slightly confusing on the first glance :)

« Previous Page Next Page »