Show all tickets if "deptid=" (so no number)

davideakc

Hi, I'm using the latest version of osTicket (1.9.12).In the file tickets.inc.php I've created a function that filters tickets automatically by deptid (and it works).Now I want to make a function that says: if the deptid is "deptid=" (so there isn't any numbers) show all tickets with the normal view...At the moment, if "deptid=" it doesn't show anything because it search the id "null" and show 0 tickets matching my criteria.How can I do this? Thanks.

Chefkeks

You could do something like this:if(!$deptid)if(empty($deptid))

davideakc

The function is this:if (isset($_REQUEST)) { $qwhere .= ' AND ticket.dept_id='.db_input($_REQUEST); $qstr .= '&deptid='.urlencode($_REQUEST);}Where do I need to put your code?Thanks.

Chefkeks

OK now I understand it's a bit more difficult than I thought. I need to take a closer look (tomorrow) how this can be solved...

davideakc

Ok, I'll wait your suggestion, many thanks!(if you know a simple way to do it by keeping "deptid=" it's ok)

davideakc

Hi @[deleted],have you got time for see this?

Chefkeks

Have had time, but couldn't really find a solution.My best suggestion is to modify the query so that you check if a department is there or not - and then it shall give you all the tickets when ticket.dept is not empty.$qwhere .= ' AND ticket.dept_id IS NOT NULL';Not sure how or if $qstr needs to be changed too, but with the above where clause all tickets which have a value under ticket.dept_id shall be displayed (at least I hope so - haven't tried).Another possibility would be to make a foreach loop and create an array or so with the tickets for each department, sort the array then by date, ticket number, or something else and then just show the array with all the tickets.

davideakc

I will explain what is my problem...I've made the change for filtering departments via id, and it works.Now my problem is this: what if I have 2 or more pages for one dept?If I filters the dept "test" with ID 1, and then I switching to page 2 for see other tickets, the link of the page number removes automatically the "deptid="... So it goes on page 2 but without "deptid=" so it loses the filter...Do you have any other idea/solution?

Chefkeks

No unfortunately I do not have an idea that really helps you :(

davideakc

Ok, so in this string:$qwhere .= ' AND ticket.dept_id='.db_input($_REQUEST);Where do I need to put this:' AND ticket.dept_id IS NOT NULL';Can you put your code in the correct way on mine?

Chefkeks

I'd just try replacing $qwhere .= ' AND ticket.dept_id='.db_input($_REQUEST);with$qwhere .= ' AND ticket.dept_id IS NOT NULL';But I'm not sure if that will work as you need it since I haven't tested it

davideakc

If I make the change you propose, I lose the query and show me all tickets even if "deptid=1" for example...