Adding a New Field to tickets: Page 5

Adding a New Field to tickets

grafcom

In include\class.client.php
Working on new var being company change following:
Line 29 add:
var $company;
Line 45 add "company" between "name," and "email"
function lookup($id,$email=''){
$sql='SELECT ticket_id,ticketID,name,company,email FROM '.TICKET_TABLE.' WHERE ticketID='.db_input($id);
if($email){ //don't validate...using whatever is entered.
$sql.=' AND email='.db_input($email);
}
Line 60 add:
$this->company = $row;
Line 84 add:
function getCompany(){
return($this->company);
}
Hope that helps.

Thanks, This did the trick

taxassist

leading zeros (0) being stripped from new fileds

does anyone know how I can prevent leading zeros from being stripped from any new fields I add. I have tried defining them as 'string' and as 'text' without any luck. This was also happening to the telephone numver but I have sorted that with the following solution.

http://www.osticket.com/forums/showthread.php?t=1789&highlight=Number+Stripping(http://www.osticket.com/forums/showthread.php?t=1789&highlight=Number+Stripping)

That solution does not effect the other fields though. I cannot work it out

masino_sinaga

Try this:

(How to Make Phone Number Started With “0″ Saved in osTicket System v1.6 RC5)

Sincerely,

Masino Sinaga

taxassist

Hi Masino,

Thanks but I have tried your solution as well. Your solution would work on other fileds just like you have shown in the telephone field however it adds the single quotes into the databse as well. so for example 078897 would be '078897'

What im trying to fugure out is which function is actually removeing the leading zero and why?

masino_sinaga

@[deleted],

What im trying to fugure out is which function is actually removeing the leading zero and why?

If you search this code from /include/class.ticket.php file:

',phone='.db_input($var).

then that code will cause the leading zero was being removed. The phone number is converted into numbers when inserted into the SQL statement. To avoid this, then you have to enclose the value with double quotes ("), since the SQL statement itself being enclosed with single quotes ('). Yeah, I know if the phone number was blank on the form, then two single quotes will be saved into database.

Sincerely,

Masino Sinaga

taxassist

@[deleted]

Yes i thought it was this code but when i did what is in your solution, even if the field is not empty it adds the single quotes around the number in the database, so for example it was '01233212331'

I have tried changeing the db_input() function itself but cannot fugure out how to prevent it removeing the zero on any fields apart from the phone number.

What I am actually doing is I have added a new field called "Franchisee ID" and all these ID number have leading zeros.

Now I am trying to figure out why I can add a number with a leading zero into the existing "Subject" field without it striping the leading zero.

Why does it not strip from the Subject field but strips from my new field? I cannot see how the Subject field is being treated differently as I have tried to copy how that field works. Any Ideas?

masino_sinaga

Honestly, after checking to my ost_ticket table, there is no single quotes that enclose the phone number value, except for the blank phone number value. FYI, I am using MySQL 5.0.51b. What MySQL version are you currently running? I am not sure whether this caused by the different MySQL version.

Based on my experience so far, if I want to store the certain data -- including numbers starting digits 0 -- to the database, then that data value must be enclosed in single quotes if the SQL statement enclosed in double quotation marks, and vice versa: the data value must be enclosed in double quotes if an SQL statement enclosed in single quotes.

Sincerely,

Masino Sinaga

taxassist

hi masino,

thanks for the reply. I am using mysql 4.somthing. i will check the exact version when I log in in a couple of hours. Do you think thats the problem?

Ok so how come the "Subject" field is not enclosed in the double qoutes but does not lose its leading zeros when just a numeric number is entered into it? its really strange? How does that field work?

taxassist

just check version masino, its 4.1.22.

still cant see how the "Subject" field is preventing the zero from being stripped even when I put a numeric value in it?

masino_sinaga

Well, it looked like I had found the cause:

Please find this code in /include/class.ticket.php file:

$fields = array('type'=>'string', 'required'=>1, 'error'=>'Subject required');

$fields = array('type'=>'phone', 'required'=>0, 'error'=>'Valid phone # required');

See its type? They are distinguished by the type. One is 'string' and the other is 'phone'.

Then, please open your /include/class.validator.php file, and find this code:

case 'phone':

case 'fax':

if(!$this->is_phone($this->input))

$this->errors=$field;

break;

afterwards, at the same file, also find this code:

function is_phone($phone) {

$stripped=eregi_replace("($|$|\-|\+)","",ereg_replace("(+)","",$phone));

return (!is_numeric($stripped) || ((strlen($stripped)<7) || (strlen($stripped)>13)))?false;

}

In other words, it looked like that this will strip that leading zero.

To anyone, please CMIIW.

Sincerely,

Masino Sinaga

taxassist

i had a look at this but there is no reason why the text or string types should do this because it doesnt do any validation on these according to this code snippet

case 'text':

case 'string':

break;

masino_sinaga

i had a look at this but there is no reason why the text or string types should do this because it doesnt do any validation on these according to this code snippet
case 'text':
case 'string':
break;

http://www.osticket.com/forums/showpost.php?p=12105&postcount=90(http://www.osticket.com/forums/showpost.php?p=12105&postcount=90)

Sincerely,

Masino Sinaga

taxassist

@[deleted],

yes but is_phone() is not called at all when the type is string or text it just breaks out of the case statement. thats what i meant in the above post.

is_phone() is only called when type is phone number, so in thoery text and string types should not get stripped but they do? However "Subjec"t feild doesnt?

masino_sinaga

If you look at this following code:

$sql= 'INSERT INTO '.TICKET_TABLE.' SET created=NOW() '.

',ticketID='.db_input($extId).

',dept_id='.db_input($deptId).

',priority_id='.db_input($priorityId).

',email='.db_input($var).

',name='.db_input(Format:($var)).

',subject='.db_input(Format:($var)).

',topic='.db_input(Format:($topicDesc)).

',phone="'.db_input($var).

'",phone_ext='.db_input($var?$var:'').

',ip_address='.db_input($ipaddress).

',source='.db_input($source);

and take a look at this section:

',subject='.db_input(Format:($var)).

Does it make sense for you?

Sincerley,

Masino Sinaga

taxassist

If you look at this following code:
$sql= 'INSERT INTO '.TICKET_TABLE.' SET created=NOW() '.
',ticketID='.db_input($extId).
',dept_id='.db_input($deptId).
',priority_id='.db_input($priorityId).
',email='.db_input($var).
',name='.db_input(Format:($var)).
',subject='.db_input(Format:($var)).
',topic='.db_input(Format:($topicDesc)).
',phone="'.db_input($var).
'",phone_ext='.db_input($var?$var:'').
',ip_address='.db_input($ipaddress).
',source='.db_input($source);
and take a look at this section:
',subject='.db_input(Format:($var)).
Does it make sense for you?
Sincerley,
Masino Sinaga

Hi Masino,

Yes but I have done the same with my new field i.e

',fran_id='.db_input(Format:($var)).

but it still strips the leading zero but in the the original "Subject" field it doesnt.

masino_sinaga

How did you write the validator for that new field?

Did you make it same as the Subject field?

Sincerely,

Masino Sinaga

taxassist

How did you write the validator for that new field?
Did you make it same as the Subject field?
Sincerely,
Masino Sinaga

The subject field is a tring type so there is no validator function for it. Remember string and text do not have any validation in the case statement here.

case 'text':

case 'string':

break;

I have spent days trying to work this out, its so strange

masino_sinaga

I did not ask you about the Subject field type. I asked you about the type of your new field (fran_id). Did you make it same as the Subject field, especially for its validator?

Sincerely,

Masino Sinaga

taxassist

I did not ask you about the Subject field type. I asked you about the type of your new field (fran_id). Did you make it same as the Subject field, especially for its validator?
Sincerely,
Masino Sinaga

yes everything is the same as the subject field. there is no validator for the subject field so there is no validator for my new field either as they are the same type .i.e. string type

masino_sinaga

Could you please upload your class.ticket.php file to this forum? So we will see your modification you have already done so far.

Sincerely,

Masino Sinaga

« Previous Page Next Page »