Why does OSTicket use inline styles?

bwd

I wanted to change the logo in the header, so uploaded my own. I wanted to make the header taller, to fit my image in (which was 78px high). I made it taller, but the image was still shrunk. Then I went into/include/client/header.inc.phpand found that line 46 includes the inline style"style="height: 5em">Why? The whole purpose of CSS is to save you having to manually edit PHP and HTML files... And in /support/assets/default/css/theme.css there is#header #logo { float: left; height: 78px; width: 368px;}which is completely overriden by the inline style! I was merrily editing #header #logo in Firebug, and wondering why it wasn't changing size...

marook

Old redundant code?Anyway, optimisation to be done... ;-)

bwd

Well, I thought you were never supposed to use inline CSS, I don't even use it when developing, it simply makes no sense. For precisely this reason - and this is something a lot of people are going to want to change - the size of their logo image. Those who don't yet understand PHP very well (like me) are going to have to delve into the .php files themselves, rather than just changing the CSS - which is why CSS exists...

ntozier

While I do not consider myself an authority over what IS or IS NOT the right way to code HTML/CSS, it is my understanding that it is generally considered best practice (by many) to avoid using inline css. While they can and do serve a purpose it's not the best way to maintain a site or a code base.That being said osTicket isn't theme-able at this time. It stands to reason that all the legacy inline styles will be removed as we continue to push towards a theme-able / skinable version. As to why the logo was made that way originally, I'm not sure and I do not think that the person who made the styles originally is even with the project anymore.