Email attachments have wrong file name (date)

sz23

Emailed attachments are named a date (the modification date I think) instead of the correct file name.

The attached image should make this problem clear.

We send the emails from a .NET4 application using the MailMessage and SmtpClient classes. I tried different combinations of settings but none of them worked. Sending emails by Outlook/Exchange causes no problems, by the way.

Is anyone familiar with this kind of problem?

Regards,

Stefan

sz23

My guess is the following:

The parser seems not to look for the entry filename="xyz.png" but just for the first entry.

The correctly parsed attachment "header" (I admittedly am not an smtp expert) from Outlook:

(...)

--_009_9FA6D4360B9AFF40947CCBBADC76495445A7F036edwgsrv024edelw_

Content-Type: image/png; name="sticks.png"

Content-Description: sticks.png

Content-Disposition: attachment; filename="sticks.png"; size=340409;

creation-date="Tue, 28 Aug 2012 12 GMT";

modification-date="Fri, 22 Jun 2012 11 GMT"

Content-Transfer-Encoding: base64

iVBORw0KGgoAAAANSUhEUgAABIMAAAK0CAYAAACQpP3YAAAAAXNSR0IArs4c6QAAAARnQU1BAACx

(...)

The wrongly parsed header:

(...)

----boundary_0_40fff369-4aac-4583-8a70-f7a077ebf429

Content-Type: image/png; name="screen0.png"

Content-Transfer-Encoding: base64

Content-Disposition: attachment;

modification-date="Mi, 29 Aug 2012 9 +0200";

creation-date="Mi, 29 Aug 2012 9 +0200"; size=70348;

filename="screen0.png"

iVBORw0KGgoAAAANSUhEUgAAA+oAAAJtCAYAAAChXIoGAAAAAXNSR0IArs4c6QAA

(...)

sz23

Bugfix

I implemented the following bugfix in include/class.mailfetch.php. It seems to solve the described issues.

This is a simple "paste" bugfix. I think perhaps this code could still be improved, e.g. by rewriting this function.

I did not check about if it is already fixed in the 1.7 pre-release.

function saveAttachments($ticket,$mid,$part,$index=0) {

global $cfg;

if($part && $part->ifdparameters && ($filename=$part->dparameters->value)){ //attachment

// BUGFIX START

foreach($part->dparameters as $dparam)

{

if(strtolower($dparam->attribute) == 'filename')

{

$filename = $dparam->value;

}

// BUGFIX END

$index=$index?$index;

if($ticket && $cfg->canUploadFileType($filename) && $cfg->getMaxFileSize()>=$part->bytes) {

//extract the attachments...and do the magic.

$data=$this->decode($part->encoding, imap_fetchbody($this->mbox,$mid,$index));

$ticket->saveAttachment($filename,$data,$ticket->getLastMsgId(),'M');

return;

}

//TODO: Log failure??

}

//Recursive attachment search!

if($part && $part->parts) {

foreach($part->parts as $k=>$struct) {

if($index) $prefix = $index.'.';

$this->saveAttachments($ticket,$mid,$struct,$prefix.($k+1));

}