Subjects get truncated after certain characters

marcus_i

Hello! I'm having some issues with osTicket.

When the system fetches a mail (I'm using IMAP, but the problem also seems to occur when I'm using POP3), it truncates the subject line after the first special character (We use Æ, Ø, and Å frequently in Norway).

Date: Sat, 18 Jun 2011 18 +0200

Subject: =?ISO-8859-1?Q?This_=C5_is_a_=C6_test?=

From: My Email Account <my@mail.no>

To: system@mail.no

Content-Type: text/plain; charset=ISO-8859-1

Test test

This message is registered with the subject "This ".

I've been unable to find a fix for this. (This poster) seems to have the same issue, but that workaround is no longer working.

I'd really appreciate some help!

Splitlocked

Fix

I had this issue too, and fixed it by modifying line 1313 in include/class.ticket.php (the postMessage method) from:

',subject='.db_input(Format:($var)).

to:',subject='.db_input(Format:( <STRONG><s>**</s>htmlspecialchars($var)<e>**</e></STRONG> )).

I believe the reason why the message body is not truncated like the subject is because the message text is stored in a TEXT column in the MySQL database, which is basically the same as a BLOB (Binary Large OBject).

Hope it helps :

ntozier

That looks like the right way to fix it. :)

Also while this isn't part of the problem, the ost_ticket table defines subject as follows:

`subject` varchar(64) NOT NULL default '',

You may also want to change that to varchar(255) to allow for longer subjects.

Splitlocked

You're right, 64 characters is an unnecessary limitation if you ask me. IMHO these two changes are worthy of being applied to osTicket. Actually, htmlspecialchars should be applied to all VARCHAR columns that takes external input.