Attachment D/L is Adding Newline to File

gadonj

When I download files that have been attached to tickets, the contents are being prefixed with a newline character. For example, if I download a png image file it will say that it is corrupt and I cannot view it when trying to open in MS Paint, but if I open the png file in Notepad++ and remove the newline character at the top and save the file I can then open it like normal. This happens to all file types, but MS Word and Adobe Reader can still process the files with the extra newline character. It seems like you'll only notice the problem with images.

I have looked through the attachment.php and changed around a few things but nothing seems to work. It simply sets the headers and calls the readfile function so it should work find. I don't see anything that would be screwing with the file data.

Anyone know how to fix that?

gadonj

I would also like to note that if I download the files from the attachment directory via FTP that they work fine. So there is obviously no problem with the file upload, just the download.

Kelli

Have you edited the headers being output at all? If so, you could be running into this: http://us3.php.net/manual/en/function.readfile.php#98046(http://us3.php.net/manual/en/function.readfile.php#98046)

You need to make sure the content length is being reported correctly and the transfer encoding is correct.

If they are, you could try 'echo ltrim(file_get_contents($file))' instead of readfile()

Also make sure you're not outputting any blank lines between the least header() and the readfile() and try removing the ?> from the end of the file...

gadonj

It turns out that my ost-config.php, which gets included pretty much everywhere, had a few extra blank lines at the bottom outside the closing <?

It took me quite a while to trace that through, but thats what the problem was.

Kelli

Well, I'm glad you tracked it down.. I'm surprised you weren't getting errors elsewhere as well, then. I've started omitting the closing ?> for that very reason.