Last week I started using osticket. It is i nice clean fast app, thanx for making and sharing.
I today found a bug:
When a user is logged in en creates a new ticket from there, the CAPCHA is not shown (good idea) but open.php does checks if the capcha code is filled in, wich will never be the case.
I Replaced:
if(!$thisuser && $cfg->enableCaptcha()){
if(!$_POST)
$errors='Enter text shown on the image';
elseif(strcmp($_SESSION,md5($_POST)))
$errors='Invalid - try again!';
}
With:
//only require CAPTCHA when user is not logged in.
if($thisclient && $thisclient->getId() && $thisclient->isValid()){
}else{
if(!$thisuser && $cfg->enableCaptcha()){
if(!$_POST)
$errors='Enter text shown on the image';
elseif(strcmp($_SESSION,md5($_POST)))
$errors='Invalid - try again!';
}
}
Witch solved the problem.
I don't see any versioning information, this problem was found in my download from last week.
Hmm, i just saw the Bug topic, this might have to be replaced to there?
