[HELP] - How to let ONLY admins sort (and see) emails?

bhoward

Hi yet again.

For one of my last hacks, I want to hide all email addresses from non-administrators. In order to do this, I assume I need to edit include/staff/viewticket.inc.php, and include/stafftickets.inc.php

I'm not good with PHP at all, but I've learned a little bit over the past few days...so I tried to do it myself. And I had some problems. :(

From viewticket.inc.php: I added the red part --

<tr>

<th>Email:</th>

<td><?php

if(($thisuser->isAdmin())) {

echo ->$ticket->getEmail();

if(($related=$ticket->getRelatedTicketsCount())) {

echo sprintf('  <a href="tickets.php?a=search&query=%s" title="Related Tickets">(<b>%d</b>)</a>',

$ticket->getEmail(),$related);

}

?>

</td>

</tr>

From tickets.inc.php: I didn't really start on this. All I was able to do was modify the table row/column sizes (see my attachment).

I need two things done for this page...

#001: Fetching "email address" information to this page.

#002: Hiding this information from non-admins.

...And I think I'd have to "create" #001 from scratch. I'm not even sure if I could just copy/paste something from include/client/tickets.inc.php, since that section already does show email addresses.

[tickets.inc.php (trying to add 'Email' column).zip](https://forum.osticket.com/assets/files/migrated/b/6e12150957a0c30cdea393806c7adb5.zip)

PRedmond

Hmm, can't look at the attachments until they are approved, soooo:

I think this is the trick:

<tr>

<th>Email:</th>

<td><?php

if(($thisuser->isAdmin())) {

// no need for the -> after echo

echo $ticket->getEmail();

if(($related=$ticket->getRelatedTicketsCount())) {

echo sprintf('  <a href="tickets.php?a=search&query=%s" title="Related Tickets">(<b>%d</b>)</a>',$ticket->getEmail(),$related);

}

?>

</td>

</tr>

bhoward

Hi again. =)

Unfortunately, your code didn't work. :( I finally managed to get the email addresses to show up, but I still can't hide them from non-admins.

Since my attachment is still "pending approval", I've included my code (on this webpage). Please let me know where to add the "isAdmin()" code; I can't figure it out at all.

PS: Could you help me on one last thing? I'm trying to make (this "Ticket Print" mod) work on client-side tickets. It only works for staff, and I can't figure out the correct code at all.

Thanks again for all the help!

bhoward

Sorry to double post, but I just had another idea!

Maybe I could make two separate files: tickets.inc.php (for staff), and ticketsAdmin.inc.php (for admins; it shows the email column). And then, all I'd need is a code that says "Load this document is the user is an admin, and load the other document if the user isn't an admin".

Now the only thing is:

1) What file would this conditional statement go in? (Is it scp/tickets.php?) And what's the correct way to write the code?

2) Would I also have to make two separate viewtickets.inc.php files? (Or is there a simple code I can use here?) I also want the email address to be hidden here too, unless you're an admin.

PRedmond

I thought I was having an issues with "isAdmin()" yesterday. I spend about 2 hours trying to figure out why a non-admin could access the admin panel. Turns out the definition of admin is slightly ambiguous.

When you create a user, you can allocate them to 'Admin', 'Manager' or 'Staff' (you can add others, but there are the 3 default options). Then further down there is a radio-button where you can make a staff member either staff or admin. If you chose 'Staff' from the dropbox, but 'Admin' from the radio-button, then the user APPEARS to be staff, but has admin access. The only way I could identify the anomaly was to look at the users in the database itself.

Now, this may NOT be the cause of your error, but it is DEFINITELY something worth checking, or you will spend a lot of time chasing code which will NEVER fix the issue...

Now, the code:

<option value="sender" <?= $sort == 'sender' ?'selected':''?>>From</option>

<option value="email" <?= $sort == 'email' ?'selected':''?>>Email</option>

</select>

I would change this to

<option value="sender" <?= $sort == 'sender' ?'selected':''?>>From</option>

<?php if ($thisuser->isAdmin()) { ?>

<option value="email" <?= $sort == 'email' ?'selected':''?>>Email</option>

<?php } ?>

</select>

You don't really want to give them the option to search by email if they can't access it.

<th width="140" >

<a href="tickets.php?sort=email&order=<?=$negorder?><?=$qstr?>" title="Sort By Email <?=$negorder?>">Email</a></th>

</tr>

would become

<?php if ($thisuser->isAdmin()) { ?><th width="140" >

<a href="tickets.php?sort=email&order=<?=$negorder?><?=$qstr?>" title="Sort By Email <?=$negorder?>">Email</a></th>

<?php } ?>

</tr>

<td nowrap><?=Format:($row,40)?></td>

would become

<?php if ($thisuser->isAdmin()) { ?>

<td nowrap><?=Format:($row,40)?></td>

<?php } ?>

So basically, the changes you have made will only appear when the user is an admin. Otherwise the screen should look the same as it did before the changes.

If you want managers to be able to view the changes, you can user $thisuser->isManager() instead. I am not certain if admins are classed as managers too, so you may need to use

if (($thisuser->isAdmin()) && ($thisuser->isManager())) {

PRedmond

Sorry - missed mentioning include/staff/viewticket.inc.php - you want to do pretty much the same thing. Have a go, and post back if you have troubles.

dag

Hello,

This is my first post in this forum. I didn't want to open a new thread since this is exactly the this I a m looking for.

First, MANY THANKS to osticket.com for your open source program. I have recently installed it on my website and it is starting to help my team a lot. There are a lot of features I didn't go through yet but I am sure they are going to further improve our website management.

Now, forgive my ignorance. I am not a programmer but I like to do things myself. It helps me learn. From what I've seen, I am sure that there are a lot of people willing to help in this forum.

Basically I am looking to hide emails from my staff. I followed the instruction given by PRedmond which I thank very much.

What I did is this (let me know what I am doing wrong):

I went to my server host.

opened File Manager

went to the include/staff/viewticket.inc.php

then went to php editor to change the code inside this page

for my surprise the code on that page was different from the code PRedmond mentioned.

Here is the code I have:

<?php

if(!defined('OSTSCPINC') || !is_object($thisuser) || !$thisuser->isStaff()) die('Access Denied');

$info=($_POST && $errors)?Format:($_POST)(); //on error...use the post data

?>

<div width="100%">

<?if($errors) {?>

<p align="center" id="errormessage"><?=$errors?></p>

<?}elseif($msg) {?>

<p align="center" class="infomessage"><?=$msg?></p>

<?}elseif($warn) {?>

<p class="warnmessage"><?=$warn?></p>

<?}?>

</div>

<table width="80%" border="0" cellspacing=1 cellpadding=2>

<form action="tickets.php" method="post" enctype="multipart/form-data">

<input type='hidden' name='a' value='open'>

<tr><td align="left" colspan=2>Please fill in the form below to open a new ticket.</td></tr>

<tr>

<td align="left" nowrap width="20%"><b>Email Address:</b></td>

<td>

<input type="text" id="email" name="email" size="25" value="<?=$info?>">

 <font class="error"><b>*</b> <?=$errors?></font>

<? if($cfg->notifyONNewStaffTicket()) {?>

   

<input type="checkbox" name="alertuser" <?=(!$errors || $info)? 'checked': ''?>>Send alert to user.

<?}?>

</td>

</tr>

<tr>

<td align="left" ><b>Full Name:</b></td>

<td>

<input type="text" id="name" name="name" size="25" value="<?=$info?>">

 <font class="error"><b>*</b> <?=$errors?></font>

</td>

</tr>

<tr>

<td align="left">Telephone:</td>

<td><input type="text" name="phone" size="25" value="<?=$info?>">

 Ext <input type="text" name="phone_ext" size="6" value="<?=$info?>">

<font class="error"> <?=$errors?></font></td>

</tr>

<tr height=2px><td align="left" colspan=2 > </td</tr>

<tr>

<td align="left"><b>Ticket Source:</b></td>

<td>

<select name="source">

<option value="" selected >Select Source</option>

<option value="Phone" <?=($info=='Phone')?'selected':''?>>Phone</option>

<option value="Email" <?=($info=='Email')?'selected':''?>>Email</option>

<option value="Other" <?=($info=='Other')?'selected':''?>>Other</option>

</select>

 <font class="error"><b>*</b> <?=$errors?></font>

</td>

</tr>

<tr>

<td align="left"><b>Department:</b></td>

<td>

<select name="deptId">

<option value="" selected >Select Department</option>

<?

$services= db_query('SELECT dept_id,dept_name FROM '.DEPT_TABLE.' ORDER BY dept_name');

while (list($deptId,$dept) = db_fetch_row($services)){

$selected = ($info==$deptId)?'selected':''; ?>

<option value="<?=$deptId?>"<?=$selected?>><?=$dept?></option>

<?

}?>

</select>

 <font class="error"><b>*</b> <?=$errors?></font>

</td>

</tr>

<tr>

<td align="left"><b>Subject:</b></td>

<td>

<input type="text" name="subject" size="35" value="<?=$info?>">

 <font class="error">* <?=$errors?></font>

</td>

</tr>

<tr>

<td align="left" valign="top"><b>Issue Summary:</b></td>

<td>

<i>Visible to client/customer.</i><font class="error"><b>* <?=$errors?></b></font><br/>

<?

$sql='SELECT premade_id,title FROM '.KB_PREMADE_TABLE.' WHERE isenabled=1';

$canned=db_query($sql);

if($canned && db_num_rows($canned)) {

?>

Premade: 

<select id="canned" name="canned"

onChange="getCannedResponse(this.options.value,this.form,'issue');this.selectedIndex='0';" >

<option value="0" selected="selected">Select a premade reply/issue</option>

<?while(list($cannedId,$title)=db_fetch_row($canned)) { ?>

<option value="<?=$cannedId?>" ><?=Format:($title)?></option>

<?}?>

</select>   <label><input type='checkbox' value='1' name=append checked="true" />Append</label>

<?}?>

<textarea name="issue" cols="55" rows="8" wrap="soft"><?=$info?></textarea></td>

</tr>

<?if($cfg->canUploadFiles()) {

?>

<tr>

<td>Attachment:</td>

<td>

<input type="file" name="attachment"><font class="error"> <?=$errors?></font>

</td>

</tr>

<?}?>

<tr>

<td align="left" valign="top">Internal Note:</td>

<td>

<i>Optional Internal note(s).</i><font class="error"><b> <?=$errors?></b></font><br/>

<textarea name="note" cols="55" rows="5" wrap="soft"><?=$info?></textarea></td>

</tr>

<tr>

<td align="left" valign="top">Due Date:</td>

<td>

PS: I cut some of the code at the end because of limitation of characters set in forum

So basically what I need to know is this:

am I doing something wrong? (am I on a completely wrong path?- again sorry for my programming ignorance)

One thing I thought of is maybe I am using another version of the osticket?

What should I do to add this "hide email from staff" modification?

Many thanks for reading this. And more thanks for replying.

Regards,

dag

Ok, after spending few hours of trial and errors I made it... Thanks again!

jdabro

Same Request but with From field

Thanks for the previous info on how to comment out the email field from Staff members, works like a charm.

I am trying to follow the example and do the same for the From Field but have had no luck. Could you please correct my programming ignorance! Thanxs in advance!

Original CODE

*************************************************************

Name:

<?=Format:($ticket->getName())?>

*************************************************************

Modification with no success:

Name:

<?php

if(($thisuser->isAdmin())) {

<?=Format:($ticket->getName())?>

}