[MOD] viewticket fix

Nachitox

I don't think that this is a MOD. For me it's a fix of the email the user received when creating a new ticket.

When you create a ticket (and autoresponse is on) you received this:

You can view this ticket's progress online here: http://HOST/view.php?e=EMAIL&t=TICKETID(http://HOST/view.php?e=EMAIL&t=TICKETID)

But if you click on that link, osTickets shows the ticket list, when it should show the ticket information.

So, in tickets.php, line 25, replace

if(($id=$_REQUEST?$_REQUEST:$_POST) && is_numeric($id)) {

for

if(($id=$_REQUEST?$_REQUEST:($_GET?$_GET:$_POST)) && is_numeric($id)) {

I hope this helps others :)

LPervak

Thanks a lot!

I was also wondering what was wrong)))

ZeroEffect

Very cool, this will come in handy.

ZeroEffect

There is a probelm with this MOD

While this script does work but there is a problem. I am using the current release osTicket 1.6. I have found that if I close all my browsers and click the link in my email the page is opened but I get a "authorization required" and must click "view status". After the button is clicked I get a list of all open tickets. Now if I click the back button on the browser I go to the ticket that was in the link.

Now I am logged in to osticket if I use that browser and go to google, facebook, MSN, and other websites. Without closing the browser if I go back and click the link in the email the ticket is opened directly Just like it should.

Here is what I see/assume/guess, The view.php file references the tickets.php file which does not authenticate a user/client, the login.php file does that then calls the tickets.php file. My thought is what if the login.php file code was also in the view.php file that is called by the emailed link? Then the login would happen and then the ticket would be displayed.

Sadly I don't code in PHP, but I can get a very basic idea of what is going on in the script. I will see what I can do but some help would be appreciated.

Thanks

ZeroEffect

I have tried a couple of things

I started to look at using this code in the view.php file.

$email=trim($_GET);

$ticketID=trim($_GET:)

if(!$errors && is_numeric($ticketID) && Validator:($email) && ($tid=Ticket:($ticketID))) {

//At this point we know the ticket is valid.

$ticket= new Ticket($tid);

//TODO: 1) Check how old the ticket is...3 months max?? 2) Must be the latest 5 tickets??

//Check the email given.

if($ticket->getId() && strcasecmp($ticket->getEMail(),$email)==0){

//valid match...create session goodies for the client.

$user = new ClientSession($email,$ticket->getId());

$_SESSION=array(); //clear.

$_SESSION =$ticket->getEmail(); //Email

$_SESSION =$ticket->getExtId(); //Ticket ID --acts as password when used with email. See above.

$_SESSION =$user->getSessionToken();

$_SESSION=$cfg->getTZoffset();

$_SESSION=$cfg->observeDaylightSaving();

//Log login info...

$msg=sprintf("%s/%s logged in ",$ticket->getEmail(),$ticket->getExtId(),$_SERVER);

Sys:(LOG_DEBUG,'User login',$msg);

//Redirect tickets.php

session_write_close();

session_regenerate_id();

<USERMENTION username="header">@header</USERMENTION>("Location: tickets.php");

require_once('tickets.php'); //Just incase. of header already sent error.

exit;

}

I thought I had something but when i tried it on another computer it didn't work. Maybe I have something left in the temporary files.

Can someone who knows PHP look at this? If I could step through the lines with a debugger I might be able to figure this out.

Thanks

ZeroEffect

Has anyone tried this with success?

Thanks

ZeroErffect

masino_sinaga

Solution

@[deleted],

Regarding your case, have you tried this (mod)? Please note that this mod also works fine in 1.6 ST version.

Hopefully it will help you. Cheers!

Sincerely,

Masino Sinaga

ZeroEffect

Thank you!!!!

:) That works perfectly! I have also saved that site. I saw a couple of things that looked good.

Thanks @[deleted] for the information.

ZeroEffect

Maxplayer14

Thanks, worked great!

passenger

@ZeroEffect,
Regarding your case, have you tried this (mod)? Please note that this mod also works fine in 1.6 ST version.
Hopefully it will help you. Cheers!
Sincerely,
Masino Sinaga

It's ok. 10x.