[MOD] Improving SysLog Page in Admin Panel

masino_sinaga

Hi,

Current condition in SysLog page (Admin Panel):

blank

Before modification:

(1) The pagination feature appears at the bottom of the table, but it does not work when you click on the second or next page,

(2) There is no label with this info “Showing x – y of y” at the top of the table list,

(3) You are not able to define the maximum record per page on the searching form,

(4) You are not able to remove one or all of the syslog records manually whereas this syslog record will be automatically removed for the certain amount of periodically that you can set it up from Setting under the Admin Panel.

So I made modification by improving this page:

blank

After modification:

(1) Now pagination feature works properly

(2) Now label with "Showing x - y of y" at the top of the list has shown up

(3) Now you are able to define the maximum record per page

(4) Now you are able to remove one or all of the syslog records manually

Full article and code:

http://www.openscriptsolution.com/2009/09/16/how-to-improve-syslog-page-in-osticket-system-v1-6-rc5(http://www.openscriptsolution.com/2009/09/16/how-to-improve-syslog-page-in-osticket-system-v1-6-rc5)

Let me know your feedback. Thanks.

Sincerely,

Masino Sinaga

durangod

Masino really great mod bud (as always with you :) ) i did find two corrections that need to be made.

first one is in your changing of include/staff/syslogs.inc.php, your sixth change down under item 1 shows the following

Find this code:

144

<tr class="<?=$class?> " id="<?=$row?>">

replace with this following code:

144

145

146

147

148

<tr class="<?=$class?> " id="<?=$row?>">

<td width=7px>

<input type="checkbox" name="ids" value="<?=$row?>" <?=$sel?'checked':''?>

onClick="highLight(this.value,this.checked);"></td>

<td>

you dont show the ending in the "find this" but you have a ending in the new code, and this in fact creates two back to back, which does not allow that "all logs" grey bar to complete. On mine i just removed that additional and it was fine..

also on item 3 you show find admin.php, but it is not in the root directory it is in the scp directory. just add scp to the front of that to avoid confusion.

thats all, really great mod and really great job... thanks so much.

masino_sinaga

durangod,

Thanks so much for your kind feedback and for the good catch including the corrections.

I have just fixed them all on my blog, so anyone will not get confused anymore. ;)

Sincerely,

Masino Sinaga

scottro

EXCELLENT MOD, Thanks very much Masino for yet another essential MOD. I really hope they put this into 1.6 ST, but I wouldn't know. I'm way to invested in hacks and MODs on 1.6RC5 to know ;)

scottro

I just found that deleting a syslog entry gives me the osTicket "White page of death". It appears to be something with the function deleteSysLog. I'm attempting to TS it now but I've only got 12 minutes left to my day so it may wait until Monday ;)

Rincewind

I just found that deleting a syslog entry gives me the osTicket "White page of death". It appears to be something with the function deleteSysLog. I'm attempting to TS it now but I've only got 12 minutes left to my day so it may wait until Monday ;)

I've got this same problem in 1.6ST

Not sure what's causing it yet. Everything looks to be fine... :-/

Found the issue. At least for me, might work for you too. The problem is in ./include/class.sys.php

As part of the mod, you're supposed to append below the following section of code:

function purgeLogs(){

global $cfg;

if($cfg && ($gp=$cfg->getLogGraceperiod()) && is_numeric($gp)) {

$sql='DELETE FROM '.SYSLOG_TABLE.' WHERE DATE_ADD(created, INTERVAL '.$gp.' MONTH)<=NOW()';

db_query($sql);

}

I suspect you did what I did which was to actually append to the following:

function purgeLogs(){

global $cfg;

if($cfg && ($gp=$cfg->getLogGraceperiod()) && is_numeric($gp)) {

$sql='DELETE FROM '.SYSLOG_TABLE.' WHERE DATE_ADD(created, INTERVAL '.$gp.' MONTH)<=NOW()';

db_query($sql);

}

Note the extra '}' - What I did was to accidentally post the function outside the class. :-/

Works now. ;)

scottro

That did it! Thanks Rincewind!

qutub110

Excellent work... now showing all statistic correctly in 1.6ST. Thanks a lot.

Rincewind

My pleasure. ;)