Departmental Privacy

durangod

Has anyone considered putting a mod together that would limit staff members to viewing only their department when clicking on the directory tab. For privacy issues there is no need for staff to have access to the entire directory, only admin level should have that access..

It would be nice if when staff clicked on directory they only were able to see their own department or own group.. maybe someone could write up a quicky that would skip that tab all together if your not admin level as a temp fix...

thanks

scottro

I think this should work for you, I just created/tested it:

scp/directory.php

~Line 23 Remove:

$WHERE=' WHERE isvisible=1 ';

Insert:

$deptID=$thisuser->getDeptID();

if($thisuser->isAdmin())

{$WHERE=' WHERE isvisible=1';
}else
{$WHERE=' WHERE isvisible=1 AND ( dept_id='.$deptID.' )';

}

scottro

You might want to do something with the search box too, otherwise people will see the other departments to search from but will never get any results.

scottro

Or I could just do it...since I was there... ;)

Same file a bit further down, inside the

Remove:

$depts= db_query('SELECT dept_id,dept_name FROM '.DEPT_TABLE);

Insert:

if($thisuser->isAdmin())

{

$depts= db_query('SELECT dept_id,dept_name FROM '.DEPT_TABLE);

}

else

{

$depts= db_query('SELECT dept_id,dept_name FROM '.DEPT_TABLE.' WHERE dept_id='.$deptID);

}

durangod

You are awesome!!!!

thank you sooooooooo much perfectttttttttt..... cant thank you enough... very happy...

scottro

Cool, happy to help!

durangod

real quick followup-dept drop down on premade reply

its the same thing on the add premade reply, there is a drop down box for the dept's im assuming the same code will work, but i dont know what file to paste it in... thanks

durangod

and the auto reply itself shows up on all depts

same for auto reply itself, not just creating thats easy with your code, but the reply itself shows up in all depts for all customers... maybe a standard one is good and just freeze it.. dont know, i dont want to cause you a crap load of coding here.. im planning on offering this for free so i think they can live with not having an option to change it ya know, just let admin have access and make a general one for all... but if its easy then thats cool too..

scottro

I think this is 2/3rds of what you are looking for:

http://osticket.com/forums/showthread.php?t=2432(http://osticket.com/forums/showthread.php?t=2432)

I have a coding problem myself right now with \'s not showing up in tickets. When I've got that figured out I can help you with the department dropdown on the other page.

durangod

thanks so much appreciate your help on that, i did post that code so i guess im 2/3 done, i did notice that the dept is also in the ticket creation also so im guessing after the premade one the create ticket box should be the last booger.. would be nice if there was a way to set this parameter globally at signon rather that each instance.. but its ok... just let me know and ill fiddle while your doing your thing, hope you get yours fixed, / are pain i know i fought with them on my other site forever before they finally figured it out... talk to ya soon, thanks dave

durangod

ok i messed around with it for over two hours and i just cant get the rest, i played with the kb.php and others, and not only the ticket but the assign ticket box at the bottom is affected too, it shows everyone not just dept.. im so sorry i really did not realize it would be so much to change these. we are almost there if we can finish thanks..

durangod

fiy i noticed i am getting a syntax error on the code sounds like a simple fix but not sure ill have to check it out.

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 1

durangod

everything is now back to where it was before all of this and im still getting the message at the bottom that says "problems displaying directory ", so i am going to totally replace all the files we modified with originals and see if that helps.. i was very detailed and very very careful when put the code in there to make sure i did it exactly right so thats not the deal..

my whole conception here is that each dept is a totally dif company so they need to be totally seperate in communication thats why im asking all this..

i will get it back to where it was totally and if i have to i will rip out options if i cant get them to do what i want.. i would rather have no option than to have abc computers be looking at ted auto service personal email address and such... there has to be a way to set each dept and the staff to itself to where dif dept and the staffs within that dept cannot look at other dept and staffs but then me as admin can see everything ... it cant be that hard ya know..

scottro

fiy i noticed i am getting a syntax error on the code sounds like a simple fix but not sure ill have to check it out.

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 1

For whatever reason your department id appears to be returning blank.

durangod

yeah i did an echo of the dept id after the field (that much i know how to do lol) and it came back nothing so i figured something was up, i replaced all the files in the staff dir, now im going to replace all the files in the src and the client dir's and thats overkill but that should fix it, only thing i have changed is the signon screens and front pages and thats just simple display html, so ill avoid those files... thanks did you get your issue fixed do you still plan on assisting further or is it too much time for ya to do?

if not ill try to come up with a test script to remove the options from the staff login entirely and only have those avail for admin.. im thinking just a simple script, are you admin fine, if not then skip this section or file process. whichever you think is best either remove or try to mod... thanks so much..

scottro

I can help but what do you have in place now? Nothing? Anything?

durangod

not much of anything, i have one client that i left an email to test it but not sure if they have or not, i have not seen any ticket come thru.. he is prob out of town.. thats good.. lol.. i just got done going thru the scp,client, staff and i replaced every file other than the index footer, header, login, and open inc php, i have set up simple html in those and dont want to loose it, but that should not be affecting it because i dont recall getting that msg until i did the current changes for some reason..

but bottom line is most everything in the file structure is back to orginal(other than that display html) and im still getting that message that cant display...

so what do you think is best now is the time to mod either way, remove features or mod... your opinion please...

scottro

I'm not sure I'm following, you completely replaced all the files instead of just putting back in the old code?

Also, this code gets the dept_id for whoever is logged in. Look in your staff database and see what dept_id your login is assigned. That should be whatever number is showing up.

durangod

i replaced the old code at first but did not work so i replaced the files because i was tired last night and im thinking ok i could of missed something simple like a , or something so replaced the files.. ill let you know on the database here in a sec

durangod

ok db looks fine, in the ost_staff staff_id group_id dept_id all have numbers in them, for example the first one is 5 4 7 in that same order and the rest looks fine no garbage or blanks that i see.