Show who closed the ticket

BernardoCR

Hello,

I don't know if I missed something on the configuration, but whenever one closes the ticket, I don't have how to know who closed the ticket.

Shouldn't a message be posted at the end of the ticket, showing:

Date, time:

Ticket closed by "Staff Name"

???

If someone could help on that..

Thanks,

Bernardo.

jpowers40828

There isn't anything that will do that, but hopefully this helps.

In scp/tickets.php ~ line 81 AFTER

if(isset($_POST) && $_POST)

$ticket->setStatus($_POST);

ADD

if(isset($_POST) && $_POST=="Close")

$ticket->postNote("Ticket Closed","Ticket closed by ".$thisuser->getName());

In scp/tickets.php ~ line 180 CHANGE

if($ticket->close()){

$msg='Ticket status set to CLOSED';

if($ticket->close()){

if($ticket->postNote("Ticket Closed","Ticket closed by ".$thisuser->getName()))

$msg='Ticket status set to CLOSED';

In scp/tickets.php ~ line 291 CHANGE

if($t && @$t->close()) $i++;

if($t && @$t->close() && $t->postNote("Ticket Closed","Ticket closed by ".$thisuser->getName())) $i++;

BernardoCR

Thanks

Thanks,

Works perfectly, and for me it's very important to know who closed the ticket.

Deep_CuTz

Thanks

Thank you very much,

This is a very easy fix, and works very well. It's great that it uses internal notes, and is easily seen.

Hopefully it will work well with a modified internal notes search.

Thanks again. :)

ar2

thanx

Worked perfectly for me.

masino_sinaga

Works good!

Yup. I have tested it. It works like a charm!

Best regards,

Masino Sinaga

rogden21

Work's great, but close on reply doesn't work

I've added the code to my tickets.php file and it works great, but when trying to close the ticket by posting a reply and selecting, "close on reply", the ticket does not close.

Please help.

jpowers40828

Send me the files you edited and I'll look through them. jpowers40828@gmail.com

rogden21

My Edited File For you to check

Attached is the tickets.php file that I have edited with this fix.

I'm looking at line 81 now, and have a feeling it may be there, where it is not closing the ticket.

Thank you for your help!

[tickets.zip](https://forum.osticket.com/assets/files/migrated/2/3bf9eb242b4ff3f2d6b1374cb53a01c.zip)

jpowers40828

Yeah, I'm fairly certain you replaced the mentioned line on 81 rather than adding the code after the mentioned line on 81. You need to uncomment out the referenced lines.

rogden21

Problem on Line 81

After testing, I have found the problem lines on line 81 of the code.

I have left line ~180, and ~290 modified so when someone decides to close a ticket using the "Action" drop down, it will leave a note.

Please let me know what you come up with.

jpowers40828

Did you try my response? On line 80, you commented out 2 lines that should have stayed, they weren't being replaced, just referenced so you knew where to add the code after.

rogden21

It Works!!

Did you try my response? On line 80, you commented out 2 lines that should have stayed, they weren't being replaced, just referenced so you knew where to add the code after.

Made the fix as you suggested. I was replacing the code, as opposed to added the line. Thank you for your help.

Below is my change to line ~81. Thank you again!!

//Set status if any., original code

if(isset($_POST) && $_POST)

$ticket->setStatus($_POST);

//Added to show name of who closed the ticket.

if(isset($_POST) && $_POST)

$ticket->postNote("Ticket Closed","Ticket closed by ".$thisuser->getName());

craigreilly

I actually changes the SQL which closes the ticket to not change the assignment to 0.

This makes it easier for us to run reports based on staff because we are now looking at an ID instead of searching thru text.

Any feelings on this method?

jpowers40828

I currently just have it not change the value of the assignment in the database as well. I think the original poster had wanted a note specifically, rather than keeping it assigned. This method does show however when a person closes a ticket, and it gets reopened by a client. It could be helpful for internal evaluation.

beeman

Has anyone managed to get this MOD working on the new version (RC5) of osTicket? I tried it but it makes no difference. Thanks.

beeman

Anyone???:(

russds

I wanted to implement this also. But it doesn't work on RC5?

beeman

Hello,

Can someone please a MOD for this on RC5:(?

Regards

Beeman

masino_sinaga

Hi Beeman,

Actually, all modification steps above on RC4 also could be implemented on RC5. Perhaps since the lines of code are different between those versions, then some people get confused about it. However, if you want to implement it on RC5, you may see it by (clicking on this link). Hope it helps.

Sincerely,

Masino Sinaga