after install - " Parse error: syntax error, .."

evernasty

When I get into admin and click on the the "osTicket Installed!" link, the error says:

Parse error: syntax error, unexpected ',' in /wsxwsx/edcedc/wwww_BFD/help/include/staff/ticket-view.inc.php on line 335

Any ideas? Thanks!

Grizly

I would either extract/replace the original ticket-view.inc.php file over that faulty one, or you could post line 335 and we can have a look.

Just checked the code from the download link above, and it doesn't have any commas on line 335.. have you modded this file?

Marked below is what it looks like:

...

/* -------- Messages & Responses & Notes (if inline)-------------*/

$types = array('M', 'R');

if($cfg->showNotesInline())

$types = 'N';

if(($thread=$ticket->getThreadEntries($types))) {

foreach($thread as $entry) {

?> /*********** LINE 335 ********************/

<table class="<?php echo $threadTypes[$entry; ?>" cellspacing="0" cellpadding="1" width="940" border="0">

<tr>

<th width="200"><?php echo Format:($entry);?></th>

<th width="440"><span><?php echo Format:($entry); ?></span></th>

<th width="300" class="tmeta"><?php echo Format:($entry); ?></th>

</tr>

...

jayveetech

We can confirm this fault

if($entry, '-')

$entry = '(EMPTY)';

?>

We have a fresh git install (I now suspect non-stable) installation (I think it might be bleeding edge even though we never changed the branch). That if statement looks like it is missing something (either a function name, or it needs to be an equality operator).

jayveetech

Using the 1.7.0 ZIP fixed the issue on our side..

Grizly

Cool. If you wanted to fix the previous version, or for others, try:

if(!isset($entry) or $entry == '-') $entry = '(EMPTY)';

jayveetech

Yeah.. Decided it would be best to go back (because I wasn't sure if it was correct, and figured there might be other issues).

Thanks,

Andy